]> dgit.raspbian.org Git - gnome-shell.git/commit
parentalControlsManager: Don't log error when disabled
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 9 Jun 2023 13:41:03 +0000 (15:41 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Fri, 9 Jun 2023 14:37:36 +0000 (16:37 +0200)
commit593f659a733d9c3b3f00bf42d918f331a1f451fa
treecd5393dd4cb0fe31364e49a9dd7358af4f4cd920
parent6b36d03ca1e2854a394eac96b885a0b8c7432011
parentalControlsManager: Don't log error when disabled

We currently special-case the DISABLED error when initializing
filtering, but not on app filter changes.

While it seems reasonable that Malcontent.Manager wouldn't emit
the signal while disabled, that's not actually true: It is emitted
when any user account information tracked by AccountsServices
changes.

Even if the signal were limited to changes of the ParentalControls
extension, it would still get emitted when app filtering *becomes*
disabled.

So regardless of potential improvements in libmalcontent itself,
we should filter out the DISABLED consistently, both when creating
the initial filter and when updating it.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6749

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2796>
js/misc/parentalControlsManager.js